Fixed #464#576
Merged
fgreinacher merged 2 commits intoTestableIO:masterfrom Apr 17, 2020
PeterDowdy:bugfix/464
Merged
Conversation
fgreinacher
reviewed
Apr 17, 2020
Contributor
|
Nice, simple fix. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #464 by using the test case provided. The change is small: StreamReader honours BOMs, but to preserve big-endian Unicode support you must pass an encoding in that case. Since encoding is always provided into that method, I pass it always.